Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federated extension script: Change package name logic #9326

Merged
merged 1 commit into from Nov 13, 2020
Merged

Federated extension script: Change package name logic #9326

merged 1 commit into from Nov 13, 2020

Conversation

martinRenou
Copy link
Member

Fix #9320

@martinRenou
Federated extension script: Change package name logic
4648e06 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 3.0 milestone Nov 13, 2020
blink1073
blink1073 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 38fba0e into jupyterlab:master Nov 13, 2020
1 check passed
@martinRenou martinRenou deleted the federated_ext_package_name_logic branch November 13, 2020 16:58
@martinRenou martinRenou mentioned this pull request Dec 10, 2020
Open
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Federated labextensions: package name logic
3 participants
@martinRenou @blink1073 @jtpio