Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of extensions that provide both prebuilt and source extensions. #9489

Merged
merged 1 commit into from Dec 18, 2020
Merged

Better handling of extensions that provide both prebuilt and source extensions. #9489

merged 1 commit into from Dec 18, 2020

Conversation

afshin
Copy link
Member

@afshin afshin commented Dec 17, 2020

References

Fixes #9277

Code changes

  • Adds handling of prebuilt extensions in the build api handler check to prevent showing a build notice for a shadowed source extension.
  • Ignores shadowed source extensions in the extension manager api handler to prevent showing shadowed source extensions.

User-facing changes

Better handling of extensions that provide both prebuilt and source extensions.

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.0 milestone Dec 17, 2020
@jasongrout
Copy link
Contributor

Thanks!

@jasongrout jasongrout merged commit 6f4ba75 into jupyterlab:master Dec 18, 2020
1 check passed
jasongrout added a commit to jasongrout/jupyterlab that referenced this pull request Dec 18, 2020
@jasongrout
Fix typo in d4af07d (jupyterlab#9489)
4c3b5cd
@jasongrout jasongrout mentioned this pull request Dec 18, 2020
Merged
jasongrout added a commit that referenced this pull request Dec 18, 2020
@jasongrout
Merge pull request #9490 from jasongrout/typo
8e3c70e 
Fix typo in #9489
@vidartf vidartf mentioned this pull request Dec 18, 2020
Closed
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Federated bundle (for JLab>=3) and source bundle (for JLlab<3) in 1 pypi package
3 participants
@afshin @jasongrout @blink1073