Move open_browser to the top level configs of classes. #9580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows on changes to Jupyter Server and ExtensionApp which moves open_browser to the ExtensionApp config. See jupyter-server/jupyter_server#375 Fixes jupyterlab#9579
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
Fixes #9579
See jupyter-server/jupyter_server#375
Code changes
This follows on changes to Jupyter Server and ExtensionApp which moves open_browser to the ExtensionApp config.
User-facing changes
Backwards-incompatible changes