Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook toolbar example docs #9705

Merged
merged 1 commit into from Feb 1, 2021

Conversation

blink1073
Copy link
Member

References

Part of 3.0 release checklist: #8038

Code changes

Update docs for the notebook toolbar example.

User-facing changes

Updated docs

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 3.0 milestone Jan 29, 2021
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with 3.0.5, copy-pasting when following the instructions all work fine. The only departure is the default name of the cookiecutter extension (default: myextension; example: my_cookie_cutter_name), but this will need to be changed by the user anyways and might be better addressed over in the cookiecutter repository if it benefits new developers.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 3af7c12 into jupyterlab:master Feb 1, 2021
1 check passed
@blink1073
Copy link
Member Author

@meeseeskdev please backport to 3.0.x

@blink1073
Copy link
Member Author

@meeseeksdev please backport to 3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Feb 1, 2021
blink1073 added a commit that referenced this pull request Feb 1, 2021
…5-on-3.0.x

Backport PR #9705 on branch 3.0.x (Update notebook toolbar example docs)
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants