Correct synchronization of tags between metadata and tags widget #9773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@meeseeksdev please backport to 3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Feb 11, 2021
…metadata and tags widget
blink1073
added a commit
that referenced
this pull request
Feb 11, 2021
…3-on-3.0.x Backport PR #9773 on branch 3.0.x (Correct synchronization of tags between metadata and tags widget)
This was referenced Mar 17, 2021
Closed
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
Fixes #9472
Code changes
Ensure the list of tags is copied so the observable object sees a change
User-facing changes
Coherent behaviour when changing tags in tags widget or metadata json.
Backwards-incompatible changes
No