From bc2b48f7f0a1bebf3279456fa81e1054b0189644 Mon Sep 17 00:00:00 2001 From: "Afshin T. Darian" Date: Tue, 16 Aug 2022 13:52:49 +0100 Subject: [PATCH] Clean up test labels as per review comments --- packages/algorithm/tests/src/map.spec.ts | 8 -------- packages/algorithm/tests/src/retro.spec.ts | 8 ++++---- packages/algorithm/tests/src/take.spec.ts | 4 ++-- 3 files changed, 6 insertions(+), 14 deletions(-) diff --git a/packages/algorithm/tests/src/map.spec.ts b/packages/algorithm/tests/src/map.spec.ts index f470513e8..dbfce8c15 100644 --- a/packages/algorithm/tests/src/map.spec.ts +++ b/packages/algorithm/tests/src/map.spec.ts @@ -19,12 +19,4 @@ describe('@lumino/algorithm', () => { return [it, result]; }); }); - - describe('map()', () => { - testIterator(() => { - let result = [0, 1, 8, 27]; - let it = map([0, 1, 2, 3][Symbol.iterator](), x => x ** 3); - return [it, result]; - }); - }); }); diff --git a/packages/algorithm/tests/src/retro.spec.ts b/packages/algorithm/tests/src/retro.spec.ts index 205835682..8c98455bc 100644 --- a/packages/algorithm/tests/src/retro.spec.ts +++ b/packages/algorithm/tests/src/retro.spec.ts @@ -24,11 +24,11 @@ describe('@lumino/algorithm', () => { let retroable = { retro: () => iterator }; expect(retro(retroable)).to.equal(iterator); }); - }); - describe('retro()', () => { - testIterator(() => { - return [retro([1, 2, 3]), [3, 2, 1]]; + it('should reverse an array', () => { + testIterator(() => { + return [retro([1, 2, 3]), [3, 2, 1]]; + }); }); }); }); diff --git a/packages/algorithm/tests/src/take.spec.ts b/packages/algorithm/tests/src/take.spec.ts index 8295ef7cb..83a3828c7 100644 --- a/packages/algorithm/tests/src/take.spec.ts +++ b/packages/algorithm/tests/src/take.spec.ts @@ -12,13 +12,13 @@ import { take } from '@lumino/algorithm'; import { testIterator } from './iter.spec'; describe('@lumino/algorithm', () => { - describe('take()', () => { + describe('take() from an array', () => { testIterator(() => { return [take([1, 2, 3, 4, 5], 2), [1, 2]]; }); }); - describe('take()', () => { + describe('take() from an iterable iterator', () => { testIterator(() => { return [take([0, 1, 2, 3][Symbol.iterator](), 1), [0]]; });