Add an option to enable the service worker cache #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Feb 20, 2024
|
Need to do a bit more testing to make sure this actually has a real effect. |
|
cc @martinRenou for an initial review, since you also opened #1294 This might still need some testing to make sure it has an actual effect. When I was trying to compare with a default deployment without this change it didn't look like the assets were served from the service worker (by looking at the dev tools). |
jtpio
force-pushed
the
service-worker-cache
branch
from
5cc6728 to
997a922
Compare
|
Getting this in so it can be tested in the next rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #1103
Also related to:
The service worker caching is probably one of the biggest frustration points for JupyterLite users. Making it an opt-in might help make the user experience smoother.
Code changes
User-facing changes
Hopefully less issues about missing files and after updating JupyterLite versions.
Backwards-incompatible changes
More of a change in behavior than a breaking change. Still need to be documented in the migration guide though.