Skip to content

Better handle text files #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2021
Merged

Better handle text files #396

merged 2 commits into from
Oct 16, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 15, 2021

References

Fixes #395

Code changes

Improve the handling of text files fetched from the server.

User-facing changes

Some files should now open in a text readable format (for example .js)

Backwards-incompatible changes

None

@jtpio jtpio added the bug Something isn't working label Oct 15, 2021
@jtpio jtpio added this to the 0.1.0 milestone Oct 15, 2021
@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Oct 16, 2021

This should already improve things.

We might want to revisit the approach or add extra mime types later.

@jtpio jtpio merged commit 353551c into jupyterlite:main Oct 16, 2021
@jtpio jtpio deleted the text-mime-types branch October 16, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Fix handling of text files
1 participant
@jtpio