Skip to content

Handle extra slash with the classic opener #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Handle extra slash with the classic opener #53

merged 1 commit into from
Apr 17, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 17, 2021

References

So classic is able to open notebooks and files even if there is an extra slash:

image

Code changes

Regex change.

User-facing changes

Backwards-incompatible changes

none

@vercel
Copy link

vercel bot commented Apr 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jtpx/jupyterlite/52KAE3x9BwudHuaLN5iV3bsSNTa8
✅ Preview: https://jupyterlite-git-extra-slash-jtpx.vercel.app

@jtpio jtpio merged commit e91c0be into main Apr 17, 2021
@jtpio jtpio deleted the extra-slash branch April 17, 2021 20:26
@jtpio jtpio added this to the 0.1.0 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant