-
Notifications
You must be signed in to change notification settings - Fork 348
Add configurable fileTypes for upload and HTTP serving #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable fileTypes for upload and HTTP serving #670
Conversation
fccd47e
to
b7387a7
Compare
The docs failed to build on the latest 5d6e522 seems to be fixing it. |
Thanks for the assist. When last I put it down, most of the arbitrary file types i tried were working for various upload/download scenarios. PDF was still bothersome. |
Yes I gave it a spin on RTD and it looked good. Let's get it in. |
.... i found one more thing with SVG... taking a look. |
right, but the more telling thing is:
I was specifically seeing SVG come out as Hate to hold things up, but getting reports like this doesn't work for my niche file format are really boring when the feature is otherwise awesome, and we have a plan for letting owners fix arbitrary formats. |
i also haven't tested any of the #655 stuff vs the webrtc backend. if it breaks that, we need to stop and re-think whether we need to be able to put all of the serviceworker stuff behind a build flag. |
hm... looks like this is breaking config somehow, e.g. not propagating |
I tried with the RTD preview for this PR, and editing seems to be working as before: New files and directories created from the kernel are not replicated across peers, but that was also the case before when creating new files from the UI. Although it's not clear yet how this will work, there will likely be substantial changes needed when updating to JupyterLab 4.0 packages with the RTC logic progressively moving to the server. |
i tried this out too... it looks like they will work, once you open them in both browsers, and somebody decides to accept the Revert option. That's good enough for me! No further changes planned (other than cleaning up the title of the PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
References
Code changes
fileTypes
, using a subset of theIRenderMime.IFileType
tojupyter-lite.json
jupyter_lite_config.json
as(extra_)file_types
which get merged togetherfile
/base64
instead ofjson
/notebook
User-facing changes
Backwards-incompatible changes