Some proposed changes

[ecodiv]

HI jsegu,

I just found your script, which I think is a nice tool which could really be useful to others.

I have made some small changes to solve some issues I had when using it. I also added the rule that the user has to select res or tiles (but cannot select both). I furthermore added a Make file, so the script can be installed using g.extension directly from github.

Are you planning to upload / submit it to the GRASS GIS addon repository? I would suggest you do. It would make it much easier for people to find and install. If you are not interested in doing this, would you mind if I do?

Cheers,

Paulo

[juseg]

Hi Paulo,

Thank you very much for sharing all your work, which I finally just had time to review (following holidays and a little injury)! I basically welcome all your changes and think the new features (more than you announced in the above message) are very useful.

I may merge r.in.worldclim.tiles functionality back into r.in.worldclim, but leave it such for now. Interactive download was something I vaguely had planned for, so thank you again very much!

I have just applied for an OSGeo ID in order to push to the GRASS GIS add-ons repository.

Julien.

[ecodiv]

Great. Yes, after the pull request I have worked on this a bit more. I am not very experienced with git, so wasn't even sure if the new changes would be automatically be included in the pull request.

I would indeed suggest to merge r.in.worldclim.tiles, just didn't find the time myself, mostly because I didn't make up my mind about the best way to organize things (in tabs).

After pushing this to the GRASS GIS addons repository, will you keep an updated version here? That might be the easiest if I have further pull requests later on.

[juseg]

OK I will think of it. I have to check how the GRASS repo works, but I guess it would make sense to have only major (and tested) releases pushed there, with intermediate development going on here.

[ecodiv]

Hi Julien, Are you still planning to upload the r.in.worldclim addon to the addon repository? As for the license, for me I have no problems in changing it to GPL >=2, but that is ultimately up to you. Cheers, Paulo

…

On 31-03-17 16:00, jsegu wrote: Hi Paulo, Thank you very much for sharing all your work, which I finally just had time to review (following holidays and a little injury)! I basically welcome all your changes and think the new features (more than you announced in the above message) are very useful. I may merge |r.in.worldclim.tiles| functionality back into |r.in.worldclim|, but leave it such for now. Interactive download was something I vaguely had planned for, so thank you again very much! I have just applied for an OSGeo ID in order to push to the GRASS GIS add-ons repository. Julien. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHdGVeb-s2ZLuFCA_ykfzrd4zLX94y24ks5rrQcQgaJpZM4MDRQC>.

[ecodiv]

Hi Paulo and all, Yes I am still planning to do so, but I would like to first merge the two scripts into one. I plan to do this sometime in the coming weeks as soon as I am done with some more urgent work. Thanks for letting me know you're OK with changing license. I am too. Cheers, Julien.