Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependencies #1342

Merged
merged 14 commits into from
Jun 7, 2023
Merged

build(deps): update dependencies #1342

merged 14 commits into from
Jun 7, 2023

Conversation

SanchithHegde
Copy link
Member

@SanchithHegde SanchithHegde commented Jun 2, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes the following changes:

  • Updates opentelemetry crates to stable version (0.19)
  • Updates AWS crates
  • Uses upstream git URL for async-bb8-diesel
  • Updates dependency versions for a few crates
  • Reorders crates and formats the Cargo.toml files
  • Moves the Rust edition, MSRV and license metadata to the workspace manifest file
  • Removes the unused examples directory
  • Moves the router build script out of the router/src directory into the router directory
  • Adds description and READMEs to all crates' metadata, removes file tree layout from READMEs from most crates

Motivation and Context

N/A

How did you test it?

Created a successful payment via Postman.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SanchithHegde SanchithHegde added A-dependencies Area: Dependencies S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 2, 2023
@SanchithHegde SanchithHegde self-assigned this Jun 2, 2023
@SanchithHegde SanchithHegde requested review from a team, jarnura and ashokkjag as code owners June 2, 2023 11:19
@lsampras lsampras added the S-blocked Status: Blocked on something else or other implementation work label Jun 2, 2023
@SanchithHegde SanchithHegde removed the S-blocked Status: Blocked on something else or other implementation work label Jun 7, 2023
Copy link
Contributor

@ashokkjag ashokkjag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we take advantage of semver and just specify the x.y or just x rather than upgrading the z everytime? (x.y.z)
  • Can we always have some github issue wherever we have a github reference in cargo.toml

@SanchithHegde
Copy link
Member Author

  • Can we take advantage of semver and just specify the x.y or just x rather than upgrading the z everytime? (x.y.z)

We can use major.minor for crates with major version >= 1, and use major.minor.patch format for crates with version 0.x.y. What do you say?

  • Can we always have some github issue wherever we have a github reference in cargo.toml

Sure! As of now, only async-bb8-diesel is used as a git dependency since it hasn't been published on crates.io. For any other crates used as git dependencies, we'll have issues to track them moving forward.

@jarnura jarnura added this pull request to the merge queue Jun 7, 2023
@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 7, 2023
Merged via the queue into main with commit bce01ce Jun 7, 2023
@SanchithHegde SanchithHegde deleted the dependency-updates branch June 7, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants