fix(logging): fix traces export through opentelemetry #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetry sdk isn't exporting traces to otel collector. This now works with batch exporter which is better for performance reasons. Pipeline is now changed to batch exporter with the timeout of 1 second.
ashokkjag
added
A-framework
lsampras
previously approved these changes
Jun 6, 2023
SanchithHegde
approved these changes
Jun 6, 2023
ashokkjag
added
S-waiting-on-review
jarnura
approved these changes
Jun 6, 2023
jarnura
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
opentelemetry sdk currently isn't exporting traces to otel collector. This now works after changing to batch exporter which is better for performance reasons. Pipeline is now changed to batch exporter with the timeout of 1 second.
Additional Changes
Motivation and Context
Traces are vital to debug failures and to diagnose latency issues. Traces aren't getting exported/reflecting in Grafana/Tempo. This change fixes the issue and traces are available in Grafana.
How did you test it?
log.telemetry.traces_enabled = trueinconfig/docker_compose.tomldocker compose -f docker-compose.yml -p hyperswitch-tempo --profile monitoring upChecklist
cargo +nightly fmt --allcargo clippy