Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Remove requires_customer_action status to payment confirm #1624

Merged
merged 4 commits into from
Jul 10, 2023
Merged

fix(router): Remove requires_customer_action status to payment confirm #1624

merged 4 commits into from
Jul 10, 2023

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This will allow the payment to be confirmed if the status is RequiresCustomerAction.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

  1. Create a payment which will move to RequiresCustomerAction.
Screen Shot 2023-07-06 at 12 49 28 PM
  1. Confirm the payment again
Screen Shot 2023-07-06 at 12 49 39 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@AkshayaFoiger AkshayaFoiger added A-core Area: Core flows C-bug Category: Bug labels Jul 6, 2023
@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner July 6, 2023 07:23
@AkshayaFoiger AkshayaFoiger self-assigned this Jul 6, 2023
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 6, 2023
@AkshayaFoiger AkshayaFoiger changed the title fix:remove requires_customer_action status to payment confirm fix(router):remove requires_customer_action status to payment confirm Jul 6, 2023
@AkshayaFoiger AkshayaFoiger changed the title fix(router):remove requires_customer_action status to payment confirm fix(router):Remove requires_customer_action status to payment confirm Jul 6, 2023
@AkshayaFoiger AkshayaFoiger changed the title fix(router):Remove requires_customer_action status to payment confirm fix(router): Remove requires_customer_action status to payment confirm Jul 6, 2023
@AkshayaFoiger AkshayaFoiger removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 6, 2023
@github-actions github-actions bot added S-conventions-not-followed Status: This PR does not follow contributing guidelines and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Jul 6, 2023
@AkshayaFoiger AkshayaFoiger removed the request for review from jarnura July 10, 2023 08:43
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 69454ec Jul 10, 2023
7 checks passed
@Narayanbhat166 Narayanbhat166 deleted the remove_validation branch July 10, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@AkshayaFoiger AkshayaFoiger

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkshayaFoiger @SanchithHegde @Narayanbhat166