Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Adyen] Add support for PayPal wallet mandates #1686

Merged
merged 13 commits into from
Jul 14, 2023
Merged

feat(connector): [Adyen] Add support for PayPal wallet mandates #1686

merged 13 commits into from
Jul 14, 2023

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add PayPal wallet mandates in Adyen connector

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

CIT -
Screen Shot 2023-07-12 at 12 48 59 PM

Screen Shot 2023-07-12 at 12 49 37 PM Screen Shot 2023-07-12 at 12 50 41 PM

MIT -
Screen Shot 2023-07-12 at 12 53 12 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 12, 2023
@prasunna09 prasunna09 added this to the July 2023 Release milestone Jul 12, 2023
@prasunna09 prasunna09 self-assigned this Jul 12, 2023
@prasunna09 prasunna09 requested review from a team as code owners July 12, 2023 07:47
@prasunna09 prasunna09 added the P-high Priority: High label Jul 12, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 12, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner July 12, 2023 19:06
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 12, 2023
srujanchikke
srujanchikke previously approved these changes Jul 13, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik approved these changes Jul 13, 2023
View reviewed changes
crates/router/src/connector/adyen/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/adyen/transformers.rs Outdated Show resolved Hide resolved
ArjunKarthik
ArjunKarthik requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@ArjunKarthik ArjunKarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comments rest looks fine

@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 13, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 13, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Jul 13, 2023
View reviewed changes
srujanchikke
srujanchikke previously approved these changes Jul 13, 2023
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Jul 13, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 14, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 82fd844 Jul 14, 2023
7 checks passed
@ArjunKarthik ArjunKarthik deleted the adyen-paypal-mandate branch July 14, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@prasunna09 @ArjunKarthik @SanchithHegde @srujanchikke