Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): detect duplicate config insert and throw appropriate error #1777

Merged
merged 4 commits into from
Jul 24, 2023
Merged

fix(config): detect duplicate config insert and throw appropriate error #1777

merged 4 commits into from
Jul 24, 2023

Conversation

NishantJoshi00
Copy link
Member

@NishantJoshi00 NishantJoshi00 commented Jul 24, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added support for handling duplicate config creation appropriately instead of throwing InternalServerError

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • compiler guided testing

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 24, 2023
@NishantJoshi00 NishantJoshi00 added this to the July 2023 Release milestone Jul 24, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner July 24, 2023 13:24
@NishantJoshi00 NishantJoshi00 self-assigned this Jul 24, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team as code owners July 24, 2023 13:24
SanchithHegde
SanchithHegde previously approved these changes Jul 24, 2023
View reviewed changes
@SanchithHegde SanchithHegde added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 1ab4226 Jul 24, 2023
9 checks passed
@SanchithHegde SanchithHegde deleted the duplicate-config-fix branch July 24, 2023 19:02
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows
Projects
None yet
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@NishantJoshi00 @SanchithHegde @sai-harsha-vardhan @Abhicodes-crypto