Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [CashToCode] Transform minor units to major units #1964

Merged
merged 2 commits into from
Aug 18, 2023
Merged

fix(connector): [CashToCode] Transform minor units to major units #1964

merged 2 commits into from
Aug 18, 2023

Conversation

nitesh-balla
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@nitesh-balla nitesh-balla added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 18, 2023
@nitesh-balla nitesh-balla self-assigned this Aug 18, 2023
@nitesh-balla nitesh-balla requested a review from a team as a code owner August 18, 2023 07:31
@nitesh-balla nitesh-balla changed the title fix(connector):[CashToCode] Transform minor units to major units fix(connector): [CashToCode] Transform minor units to major units Aug 18, 2023
@github-actions github-actions bot added S-conventions-not-followed Status: This PR does not follow contributing guidelines and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Aug 18, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 18, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit ff2efe8 Aug 18, 2023
11 of 13 checks passed
@ArjunKarthik ArjunKarthik deleted the cashtocode-hotfix-amount branch August 18, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@nitesh-balla nitesh-balla

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitesh-balla @ArjunKarthik @srujanchikke @SanchithHegde