Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Bluesnap] Update incoming Webhooks flow #1982

Merged
merged 7 commits into from
Aug 24, 2023
Merged

fix(connector): [Bluesnap] Update incoming Webhooks flow #1982

merged 7 commits into from
Aug 24, 2023

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented Aug 22, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Webhooks are updated to handle security headers which in turn helps in source verification
Also WebhookResourceObject is constructed in order to be handled by Psync handle response.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Currently Webhooks are not able to do source verification

How did you test it?

Incoming Webhook:
Screen Shot 2023-08-22 at 7 12 16 PM

Outgoing Webhook:
Screen Shot 2023-08-22 at 7 13 08 PM

Source verified:
Screen Shot 2023-08-22 at 7 13 51 PM

Unit Tests:
Screen Shot 2023-08-23 at 4 30 07 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 22, 2023
@SamraatBansal SamraatBansal requested a review from a team as a code owner August 22, 2023 13:41
@SamraatBansal SamraatBansal self-assigned this Aug 22, 2023
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 22, 2023
@ArjunKarthik
Copy link
Contributor

Is this tested for Refund webhooks?

@SamraatBansal
Copy link
Contributor Author

Is this tested for Refund webhooks?

Refund Webhooks are not supported, Bluesnap only triggers a refund Webhooks when it is issued not on status changed

@SamraatBansal SamraatBansal requested a review from a team as a code owner August 23, 2023 11:01
@ArjunKarthik ArjunKarthik removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 23, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Aug 23, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Aug 24, 2023
@SamraatBansal SamraatBansal added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Aug 24, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Aug 24, 2023
@ArjunKarthik ArjunKarthik removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 24, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 8c066d3 Aug 24, 2023
10 checks passed
@ArjunKarthik ArjunKarthik deleted the bluesnap-webhooks branch August 24, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamraatBansal @ArjunKarthik @SanchithHegde @swangi-kumari