fix: proper error message for payment confirm with already successful/failed payments#456
Merged
Conversation
Sangamesh26
added
A-core
Narayanbhat166
previously approved these changes
Jan 23, 2023
Sangamesh26
dismissed stale reviews from Narayanbhat166 and dracarys18
via
7d722ca
jarnura
approved these changes
Jan 23, 2023
jarnura
added
S-ready-to-merge
and removed
S-waiting-on-review
dracarys18
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When the payment is successful or failed and confirm call is done for that payment id, the message should be proper indicating it was failed or succeeded instead of general message
Motivation and Context
Proper error message for the payment confirm with already succeeded/failed payment
How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy