Restore simple configuration of favicon.ico #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the need to add a link to favicon,ico when editing `_includes/head_custom.html`, and avoid creating an invalid favicon link - Remove the content of `_includes/head_custom.html` - Add code to `_includes/head.html` to create a link to an existing favicon,ico - Add an explanation of favicon_ico to docs/configuration.md - Remove the example of `includes/head_custom.html` and add an explanation of what the `<head>` element automatically includes
mattxwang
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Yes! This makes more sense now. Thank you for understanding my concern and addressing this @pdmosses 🙌
|
@mattxwang Thanks for looking at this issue again – and so quickly! I guess I spent more time looking for a simpler way of testing for existence of a named file than actually coding it. Perhaps the best place to credit as prior art is Jekyll issue #7528. |
|
@MichelleBlanchette I should apologise for originally being too dismissive in my response to your original comment. I'd understood your concern, but I hadn't seen how we might address it better. @Potherca's objection to the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the need to add a link to favicon.ico when editing
_includes/head_custom.html, and avoid creating an invalid favicon link_includes/head_custom.html_includes/head.htmlto create a link to an existing favicon.icofavicon_icoto docs/configuration.md_includes/head_custom.html, and add an explanation of what the<head>element automatically includes, in docs/customization.mdSee this comment by @MichelleBlanchette and my subsequent comments for some background.
To some extent, this PR reverts PR #1027.
To test
Build and serve this PR branch locally.
Move
favicon.icotoassets/images/, then rebuild this website.Check that the favicon has disappeared, and that Jekyll does not report "ERROR '/favicon.ico' not found".
Set
favicon_ico: /assets/images/favicon.icoin_config.yml, then rebuild this website.Check that the favicon has reappeared.
Move the favicon back to the root directory, and remove the setting of
favicon_ico.