From a239db038c1d6522712e578e20bcc864eeeafb76 Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Mon, 5 Nov 2018 10:40:38 -0500 Subject: [PATCH 1/3] I think this is the fix --- src/BCC.Web/Services/GitHub/GitHubAppModelService.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs b/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs index 547dca0..ca98464 100644 --- a/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs +++ b/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs @@ -152,6 +152,8 @@ public async Task UpdateCheckRunAsync(long checkRunId, string owner, string repo { Output = new NewCheckRunOutput(createCheckRun.Title, createCheckRun.Summary) { + Text = createCheckRun.Text, + Images = createCheckRun.Images?.Select(image => new NewCheckRunImage(image.Alt, image.ImageUrl) { Caption = image.Caption }).ToArray(), Annotations = annotations .Select(CreateNewCheckRunAnnotation) .ToArray() From 858a21d3b435791a13d1e7d0bb371543eeeb52a0 Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Tue, 6 Nov 2018 10:47:22 -0500 Subject: [PATCH 2/3] Checking the limits --- src/BCC.Web/Services/CheckRunSubmissionService.cs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/BCC.Web/Services/CheckRunSubmissionService.cs b/src/BCC.Web/Services/CheckRunSubmissionService.cs index d46ba13..d566ccd 100644 --- a/src/BCC.Web/Services/CheckRunSubmissionService.cs +++ b/src/BCC.Web/Services/CheckRunSubmissionService.cs @@ -1,5 +1,6 @@ using System; using System.IO.Abstractions; +using System.Text; using System.Threading.Tasks; using BCC.Core.Model.CheckRunSubmission; using JetBrains.Annotations; @@ -56,6 +57,15 @@ public Task SubmitAsync([NotNull] string owner, [NotNull] string repos var createCheckRun = JsonConvert.DeserializeObject(readAllText); + if (createCheckRun.Summary != null) + { + var byteCount = Encoding.Unicode.GetByteCount(createCheckRun.Summary) / 1024.0; + if (byteCount > 128.0) + { + throw new InvalidOperationException(); + } + } + return _gitHubAppModelService.SubmitCheckRunAsync(owner, repository, sha, createCheckRun); } } From 001fa8d7189f45fe9a7457fba8b9173dc451c1f8 Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Tue, 6 Nov 2018 10:47:34 -0500 Subject: [PATCH 3/3] Revert "I think this is the fix" This reverts commit a239db038c1d6522712e578e20bcc864eeeafb76. --- src/BCC.Web/Services/GitHub/GitHubAppModelService.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs b/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs index ca98464..547dca0 100644 --- a/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs +++ b/src/BCC.Web/Services/GitHub/GitHubAppModelService.cs @@ -152,8 +152,6 @@ public async Task UpdateCheckRunAsync(long checkRunId, string owner, string repo { Output = new NewCheckRunOutput(createCheckRun.Title, createCheckRun.Summary) { - Text = createCheckRun.Text, - Images = createCheckRun.Images?.Select(image => new NewCheckRunImage(image.Alt, image.ImageUrl) { Caption = image.Caption }).ToArray(), Annotations = annotations .Select(CreateNewCheckRunAnnotation) .ToArray()