Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

ExternalProxy interface #662

Merged
merged 4 commits into from
Nov 17, 2019
Merged

ExternalProxy interface #662

merged 4 commits into from
Nov 17, 2019

Conversation

@ByronAP
Copy link
Contributor

@ByronAP ByronAP commented Nov 17, 2019

Changes ExternalProxy params to IExternalProxy so a custom class can be used when needed and makes ExternalProxy use IExternalProxy. ExternalProxy is still used as a default class internally.

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against the master branch

@honfika honfika merged commit 347c310 into justcoding121:master Nov 17, 2019
@ByronAP ByronAP deleted the use-interfaces branch November 18, 2019 02:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ByronAP @honfika