Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create nuget packages #300

Merged
merged 8 commits into from Feb 1, 2017
Merged

Create nuget packages #300

merged 8 commits into from Feb 1, 2017

Conversation

slang25
Copy link
Member

@slang25 slang25 commented Jan 31, 2017

No description provided.

@AnthonySteele
Copy link
Contributor

AnthonySteele commented Jan 31, 2017 •
edited

The ^M line ending is back :( I think that it's an escaped carriage return? Do you use vim? Is the issue ordering of the "0xD 0xA" characters?
http://stackoverflow.com/questions/5843495/what-does-m-character-mean-in-vim

@slang25
Copy link
Member Author

slang25 commented Jan 31, 2017

Weird, I'm using VSCode with the editorconfig plugin. I will make some changes. Could be a combination of the .gitattributes and .editorconfig or it may be the line endings in this repo aren't quite right at the moment. Will investigate later.

@AnthonySteele
Copy link
Contributor

It's possible that .gitattributes and .editorconfig are fighting.

@AnthonySteele
Copy link
Contributor

👍 Looks good to me, shall I merge?

@slang25
Copy link
Member Author

slang25 commented Jan 31, 2017

Not yet, still experimenting, having an open PR is the easiest way. Let me tag with WIP

@slang25 slang25 changed the title Create nuget packages Create nuget packages [WIP] Jan 31, 2017
martincostello
martincostello reviewed Jan 31, 2017
View reviewed changes
JustSaying.AwsTools.IntegrationTests/project.json Outdated
}
}
{
"version": "5.0.*-beta01",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using a bigger zero-pad (0001) just in case we get in a scenario where we just use the auto-generated build numbers and then it gets into the hundreds/thousands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we're generating the beta numbers, just manually counting. I really hope that there won't be 99 of them!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough if it's always manual then. I use the AppVeyor build number so I can auto-publish/consume from the AppVeyor feed on push so each build gets a unique version.

@slang25
Copy link
Member Author

slang25 commented Jan 31, 2017

@martincostello Do you have any suggestions on how to easily set the project.json version number? I'm googling now, but not sure I can do what I want with dotnet build --version-suffix ...

@martincostello
Copy link
Member

martincostello commented Jan 31, 2017 •
edited

@slang25 I do something like this with one of my packages and then push that in with --version-suffix (here and here). You can see the result here.

@slang25
Copy link
Member Author

slang25 commented Jan 31, 2017

Nice @martincostello 👍
@AnthonySteele what shall we do for this beta? Do we want the version numbers: 5.0.123-beta01
where 123 is the AppVeyor incrementing build number? If so then I think we'll need to do something to rewrite the project.json files

@AnthonySteele
Copy link
Contributor

I don't really mind. If it's easier, then go to generated 3-digit beta numbers, e,g 5.0.0-beta123

@stuart-lang
Copy link

This would be inconsistent with previous versioning and it doesn't change the assembly version info (I think), not sure if we care about this?

@AnthonySteele
Copy link
Contributor

What do you recommend?

@martincostello
Copy link
Member

Wouldn't using the assembly info patching feature of AppVeyor fix the major.minor.revision numbers?

@slang25
Copy link
Member Author

slang25 commented Jan 31, 2017 via email

@slang25 slang25 changed the title Create nuget packages [WIP] Create nuget packages Jan 31, 2017
@slang25
Copy link
Member Author

slang25 commented Jan 31, 2017

Ok, I think I am happy with this now. @AnthonySteele @martincostello please review.

@slang25
Copy link
Member Author

slang25 commented Feb 1, 2017

Although, after doing some digging it looks like the general convention people are using is 5.0.0-beta1, and we should change from incrementing the build number only on package releases. This is an easy change to make.

martincostello
martincostello reviewed Feb 1, 2017
View reviewed changes
appveyor.yml
test_script:
- dotnet test .\JustSaying.AwsTools.UnitTests\project.json
- dotnet test .\JustSaying.Messaging.UnitTests\project.json
- dotnet test .\JustSaying.UnitTests\project.json
after_build:
- dotnet pack "JustSaying" -o artifacts --no-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use --include-symbols to make a symbols package with the PDBs in as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, it's doing it anyway.

@martincostello
Copy link
Member

martincostello commented Feb 1, 2017 •
edited

LGTM.

@AnthonySteele AnthonySteele merged commit 3b006c5 into justeattakeaway:develop Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonySteele AnthonySteele AnthonySteele left review comments

@martincostello martincostello martincostello left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slang25 @AnthonySteele @martincostello @stuart-lang