feat(problems): add use_pretty_numbers function (#41)

- sets a global that causes `rand_number` to return pretty coefficients for use in problems (1-12 ints)
 - when turned off generate floats and large ints as before.

Author: justindujardin

libraries/mathy_python/mathy/problems.py

@@ -11,6 +11,7 @@
 common_variables = list("xyz")
 variables = list("abcdfghjklmnopqrstuvwxyz")
 max_const = 12
+_pretty_numbers = True
 
 
 class MathyTermTemplate(BaseModel):
@@ -109,12 +110,27 @@ def maybe_power(percent_chance=80, max_power=4, or_else=""):
         return or_else
 
 
+def use_pretty_numbers(enabled: bool = True):
+    """Determine if problems should include only pretty numbers or 
+    a whole range of integers and floats. Using pretty numbers will
+    restrict the numbers that are generated to integers between 1 and
+    12. When not using pretty numbers, floats and large integers will
+    be included in the output from `rand_number`"""
+    global _pretty_numbers
+    _pretty_numbers = enabled
+
+
 def rand_number():
-    min_value = -10000
-    max_value = 10000
+    global _pretty_numbers
+    if _pretty_numbers:
+        min_value = 1
+        max_value = 12
+    else:
+        min_value = -10000
+        max_value = 10000
     # Use an integer?
-    if rand_bool(66):
-        if rand_bool(50):
+    if _pretty_numbers or rand_bool(66):
+        if _pretty_numbers or rand_bool(50):
             result = random.randint(min_value, max_value)
         else:
             result = random.randint(1, max_const)
@@ -539,4 +555,3 @@ def gen_move_around_blockers_two(number_blockers: int, powers_probability: float
         three_exp,
     )
     return problem, complexity
-

libraries/mathy_python/tests/test_problems.py

@@ -0,0 +1,25 @@
+import pytest
+import random
+from mathy.problems import rand_number, use_pretty_numbers
+
+
+def test_number_generation() -> None:
+
+    random.seed(1337)
+
+    # When using pretty number generation, all values
+    # are in range 1-12 and are always integers
+    use_pretty_numbers(True)
+    pretty_numbers = [rand_number() for _ in range(256)]
+    outside_range_floats = [f for f in pretty_numbers if f < 1 or f > 12]
+    pretty_floats = [f for f in pretty_numbers if isinstance(f, float)]
+    assert len(outside_range_floats) == 0
+    assert len(pretty_floats) == 0
+
+    # When not using pretty numbers, values can be floats and large integers
+    use_pretty_numbers(False)
+    rand_numbers = [rand_number() for _ in range(256)]
+    large_ints = [f for f in rand_numbers if isinstance(f, int) and f > 12]
+    rand_floats = [f for f in rand_numbers if isinstance(f, float)]
+    assert len(large_ints) > 0
+    assert len(rand_floats) > 0