Permalink
Browse files

ActiveSupport::OrderedHash not autoladed in Rails 4

  • Loading branch information...
1 parent 0b929a2 commit ba055ccff074d5dd8d9ac73810811e006f370ade @twalpole twalpole committed Apr 16, 2012
Showing with 1 addition and 0 deletions.
  1. +1 −0 spec/spec_helper.rb
View
@@ -6,6 +6,7 @@
require 'action_view'
require 'action_controller'
require 'action_dispatch'
+require 'active_support/ordered_hash' #Rails 4 no longer autoloads ActiveSupport::OrderedHash
require File.expand_path(File.join(File.dirname(__FILE__), '../lib/formtastic/util'))
require File.expand_path(File.join(File.dirname(__FILE__), '../lib/formtastic'))

4 comments on commit ba055cc

I think that this change will be reverted at Rails. More info

Collaborator

twalpole replied Apr 17, 2012

If it is reverted I can revert the commit, right now it's needed for the tests to pass

Collaborator

mjonuschat replied Apr 17, 2012

Rails 4 won't need ordered hash since it drops Ruby 1.8 support

Collaborator

twalpole replied Apr 17, 2012

@yabawock Right - the question is whether they leave it in ActiveSupport for ease of backwards compatability in all the gems that will want to maintain Rails 3 and 4 compatibility in 1.8.x (for 3) and 1.9.3+, or if they remove it completely. If they remove it completely then there will need to be changes in the tests here. That being said it looks like tenderlove has reverted the removal of autoload so I'll revert this commit

Please sign in to comment.