Skip to content
Commits on Nov 23, 2009
  1. @grimen

    Correcting the required_string-bug once again: I18n translation was n…

    grimen committed with
    …ot working. Adding a spec this time. =)
Commits on Nov 22, 2009
  1. @grimen

    Using interned strings whenever possible and where it makes sense (St…

    grimen committed with
    …ring => Symbol), and concat (<<) instead of appending (+). Closes #45.
  2. @grimen
Commits on Nov 21, 2009
  1. @grimen

    Label-issues:

    grimen committed with
      * Inputs with legends as labels now got class "label" on the legend to make the styling of these much easier.
      * Inputs with legends as labels now wraps a label instead of a span, and the label is "connected" (with the "for" HTML attribute) to the first of the wrapped inputs - clicking label gives focus to this input. Reasons: Better form accessibility/usability, and is semantically more correct.
      * Removed: :as_span-option for the Formtastic label helper - not needed anymore.
    
    Closes #101.
  2. @grimen

    It's now possible to specify hidden input value using html_options[:v…

    grimen committed with
    …alue] as well - for consistency, i.e. avoiding confusion.
  3. @grimen

    Fixing a Ruby 1.8 bug introduced in on of the previous commits. Specs…

    grimen committed with
    … run and pass on 1.8, 1.9.1, and jruby.
  4. Revert "This reverts commit 440bd2d."

    committed
    This reverts commit e4fc2be.
Commits on Nov 18, 2009
  1. This reverts commit 440bd2d.

    committed
    This reverts commit 8eaa193.
    This reverts commit 8c20fb2.
    This reverts commit 3cad250.
    This reverts commit 269e530.
    This reverts commit e3c200a.
  2. @grimen

    Added support explicit values of type Range for the :collection optio…

    grimen committed with
    …n of the select input, e.g. form.input :rating, :as => :select, :collection => 1..5. Added specs for both ranges, and explicit array values which was lacking. Closes #115.
  3. @grimen

    Comment for protected helper method added in previous commit, and mak…

    grimen committed with
    …ing the only private method to protected for consistency.
  4. @grimen

    DRYer fieldset legends; check if first inputs block argument is a val…

    grimen committed with
    …id legend - the options (:name/:title) way works still, and got higher priority. Closes #106.
  5. @grimen

    Added specs for boolean select/collection, and yes/no values back to …

    grimen committed with
    …Symbols for convention - in a way that works this time.
  6. @grimen

    Adding "::" to I18n and Formtastic constants to avoid namespace issue…

    grimen committed with
    …s (especially a issue in Ruby 1.9). Closes #109.
Commits on Nov 15, 2009
Commits on Nov 14, 2009
  1. Spec Refactor:

    committed
    * replaced a bunch of verbose and repetitive specs with macros
    * now that we have macros, we can be more verbose with the input specs, rather than looping over magical hashes
  2. documentation

    committed
  3. Refactored the code and specs to be more verbose and explicit about t…

    committed
    …he path through the code and which :as options map to which methods inside the code. More to come, but I'm trying to make the code more accessible and readable.
  4. Added :group_by option to select input (issue #54)

    Jeroen van Dijk committed with
    E.g.
      f.input :author, :group_by => :continent
    
    It works a bit different compared to the #grouped_options_select method of Rails. It will collect #continent
    from each author instead of collecting authors from all continents. Under the cover it will use the Rails implementation however.
    The Rails implementation combined with ActiveRecord causes an n + 1 query problem. I have tried to minimize this but the issue remains.
Commits on Nov 10, 2009
  1. :radio inputs can now force one of the radio buttons to be pre-select…

    committed
    …ed with the :selected option, just like :select inputs, resolving issue #112.
Commits on Nov 9, 2009
  1. removed the generic method_name class from wrappers, resolving (with …

    committed
    …some protest I imagine) issue #102
  2. Add :first inline error type

    Philippe committed with
Commits on Oct 26, 2009
  1. @robertwahler
Commits on Oct 24, 2009
  1. Resolves issue #87 (a bug introduced in d8290cf), in which two labels…

    committed
    … were being rendered in boolean inputs.
    
    * input_spec.rb changed to ensure only one label rendered, exposing the bug
    * boolean_input now inserts the checkbox input into the options hash to pass to the label()
    * label() now knows what to do with the special key in the options hash, inserting the input into the label at the last minute (after i18n, etc)
    
    This will all probably be undone when/if we move the input outside the label (issue #60) :)
  2. @grimen

    commit_button now automatically get a class attribute that reflects o…

    grimen committed with
    …n REST actions whenever possible: "create", "update", or "submit". Also removed a tiny typo from the previous commit (commit_button I18n-features).
  3. @grimen

    New I18n-features:

    grimen committed with
      * Added support for I18n on buttons (commit_button) using same API as legends/labels/hints - with edited/new specs.
      * Squashed a bug that caused named models (symbol name of a class instead of an object: :post vs. @post) to not be able to lookup correct values. Specs subset of above.
      * Some small localization lookup issues justified while on it.
Commits on Oct 23, 2009
  1. @grimen
  2. @grimen
Commits on Oct 21, 2009
  1. @zuf

    Add version field (used in acts_as_versioned) to array of prohibited …

    zuf committed with
    …fields %w[created_at updated_at created_on updated_on lock_version]
  2. @grimen
Commits on Oct 18, 2009
  1. @elandesign
Commits on Oct 14, 2009
  1. Reverting "rm'ing some encoding comments"

    committed
    This reverts commit 406dbb4.
Something went wrong with that request. Please try again.