Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

required string bug #134

Closed
grimen opened this Issue Nov 22, 2009 · 4 comments

Comments

Projects
None yet
2 participants
Owner

justinfrench commented Nov 23, 2009

I'm 99%b certain this will fail now that I've addressed an issue with the specs which were masking the previous bug (and this bug ;)). See http://github.com/justinfrench/formtastic/commit/8fb11e177a3ecc0d0847ca8fbc83f4caf95544fd

Owner

justinfrench commented Nov 23, 2009

So, we just need to find a way for this that actually works. I tried your version, and also template.content_tag, both failed. I've reverted it back to the old hand-coded HTML string for now, so this isn't super critical, it's just a refactor/clean-up for 1.0.

Contributor

grimen commented Nov 23, 2009

Weird...I didn't write any specs because I didn't know how to spec it and also I thought that would work hands down. Well the old string version is okay I guess; I was just doing the content_tag while I was on it...the I18n stuff was the important change.

Owner

justinfrench commented Nov 23, 2009

Closing,,,

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment