customisation of day/month/year labels in date/time #145

Closed
justinfrench opened this Issue Dec 2, 2009 · 11 comments

Projects

None yet

4 participants

@justinfrench
Owner

Add :labels option to date(_time)_select so you can override the day, month and year labels locally instead of via I18N.

Spotted in my forkqueue:
http://github.com/karsthammer/formtastic/commit/536fa07e21bf099ba0e81cf784d1697b300dee77

What do we think?

@grimen
grimen commented Dec 2, 2009

I'll let you club that, I remember you mentioned that you maybe wanted to remove the :label option in the future clean up the API? I'm more pro than con, but don't really got an opinion right now. =)

@justinfrench
Owner

Is the patch solid? If so, I'd like to apply it, as it's a missing feature (under the assumption we're sticking with the current API, which we are).

@josevalim

The patch is good, but as already pointed, misses specs and docs.

@karsthammer

I just spotted your comments, I will try to write the docs and specs for it somewhere this week.

@justinfrench
Owner

Fantastic!

@josevalim

Wasn't it formtastic?

@justinfrench
Owner

;)

@justinfrench
Owner

Still looking for specs and docs, otherwise I'm closing.

@karsthammer

specs and docs added. See http://github.com/karsthammer/formtastic (last two commits)

@justinfrench
Owner

Awesome, tags updated. Will pull in soon.

@justinfrench
Owner

This was pulled in, closing.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment