Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 3 deprecations #242

Closed
christiannelson opened this issue Apr 18, 2010 · 5 comments
Closed

Rails 3 deprecations #242

christiannelson opened this issue Apr 18, 2010 · 5 comments

Comments

@christiannelson
Copy link

We're using formtasic (rails3 branch) on a rails 3 project (currently 3.0.0.beta3) and it's working well, with the exception of two deprecation warnings:

DEPRECATION WARNING: Errors#on_base have been deprecated, use Errors#[:base] instead. (called from on_base at /Users/christian/.rvm/gems/ruby-1.8.7-p249@imfuna/gems/activemodel-3.0.0.beta3/lib/active_model/deprecated_error_methods.rb:14)

DEPRECATION WARNING: human_name has been deprecated, please use model_name.human instead. (called from commit_button at /Users/christian/.rvm/gems/ruby-1.8.7-p249@imfuna/bundler/gems/formtastic-4b8f4f92045e9cc3ab8830590d1feeeed0fb6cab-rails3/lib/formtastic.rb:330)

They look like easy changes, but I haven't had a chance to try fixing them myself.

@sobrinho
Copy link
Member

Thanks for reporting, I will fix this

@mjonuschat
Copy link
Contributor

Fixed in commits a722680 and 39c22b1

@christiannelson
Copy link
Author

yabawock: woah, thanks for the fast turnaround. I just updated and one of the warnings (on_base) is gone but the human_name one lives on:

DEPRECATION WARNING: human_name has been deprecated, please use model_name.human instead. (called from commit_button at /Users/christian/.rvm/gems/ruby-1.8.7-p249@imfuna/bundler/gems/formtastic-8ab93b34c3a97eee21e38185e14bed2f769c81e5-rails3/lib/formtastic.rb:333)

@sobrinho
Copy link
Member

Fixed on 07f0156. Need specs but for now this fix.

@christiannelson
Copy link
Author

That did it... thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants