Rename :label_method, :value_method, etc #533

Closed
justinfrench opened this Issue Apr 16, 2011 · 1 comment

Projects

None yet

1 participant

@justinfrench
Owner

They're no longer just dealing with methods (procs, helper methods, methods on objects), and I feel like :label can be confused with the other :label.

How about :member_* (as in member of the collection)?

  • :member_label
  • :member_value
  • :member_title (separate issue)
  • etc

Obviously need to allow backwards compatibility for a while.

@justinfrench justinfrench was assigned Apr 16, 2011
Owner

Doing this now. Also renaming :group_value_method to just :group_value, although I'm thinking about deprecating that bad boy.

@justinfrench justinfrench added a commit that closed this issue May 4, 2011
@justinfrench Renamed (with backwards compatibility) and deprecation notices) :labe…
…l_method => :member_label, :value_method => :member_value and :grouped_label_method => :grouped_label. Fixes #533.
454dd44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment