Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Rename :label_method, :value_method, etc #533

Closed
justinfrench opened this Issue · 1 comment

1 participant

Justin French
Justin French

They're no longer just dealing with methods (procs, helper methods, methods on objects), and I feel like :label can be confused with the other :label.

How about :member_* (as in member of the collection)?

  • :member_label
  • :member_value
  • :member_title (separate issue)
  • etc

Obviously need to allow backwards compatibility for a while.

Justin French justinfrench was assigned
Justin French
Owner

Doing this now. Also renaming :group_value_method to just :group_value, although I'm thinking about deprecating that bad boy.

Justin French justinfrench closed this issue from a commit
Justin French Renamed (with backwards compatibility) and deprecation notices) :labe…
…l_method => :member_label, :value_method => :member_value and :grouped_label_method => :grouped_label. Fixes #533.
454dd44
Kjel Delaey trimentor referenced this issue from a commit
Justin French Renamed (with backwards compatibility) and deprecation notices) :labe…
…l_method => :member_label, :value_method => :member_value and :grouped_label_method => :grouped_label. Fixes #533.
8d4d9ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.