Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[PATCH] Allow translations to use different word ordering for commit button text #55

Closed
l15n opened this Issue · 5 comments

3 participants

@l15n

The current commit button text generation doesn't use interpolation, so languages that have a different word ordering from English are forced to override the button label text. This can be solved pretty easily by using Rails I18n's interpolation feature.

Patch here: http://github.com/l15n/formtastic/commit/7d608beafda5e7b1cba596353154fd68e97e7d8a

@grimen

The reason the new I18n lookup features haven't been adopted to the buttons is that there's sort of a question mark whether the button DSL needs an update to support additional actions, and/or options. This could work as a temporary solution though.

@l15n

I see. In the meantime, this should be the easiest thing that could possibly work, as such.

@justinfrench

Grimen, if we can get this in to keep the current API "complete", that'd be great. Then we can design the big beast ASAP :)

@grimen

Yes, I didn't plan to touch anything relating to that myself until we know which direction to go - so no worries! ;)

@justinfrench
Owner

pulled in, thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.