Error in current test and possible new feature requirement #954

Closed
twalpole opened this Issue Jul 11, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@twalpole
Collaborator

twalpole commented Jul 11, 2013

There is an error in select_input_spec

https://github.com/justinfrench/formtastic/blob/master/spec/inputs/select_input_spec.rb#L231

If rails 4 still supported the conditions option on associations the test should be

::Author.should_receive(:where).with({:active => true})

however rails 4 dropped support for the conditions option and now the reflection has a scope method that returns the scope used to limit associations, which we probably need to support. Not sure if I'll time to get this today so adding this issue to track it. If anyone else wants to handle it feel free to

@justinfrench

This comment has been minimized.

Show comment
Hide comment
@justinfrench

justinfrench Apr 19, 2014

Owner

@twalpole I think I discovered and corrected this in #1025 — can you take a look and re-open this if I'm wrong?

Owner

justinfrench commented Apr 19, 2014

@twalpole I think I discovered and corrected this in #1025 — can you take a look and re-open this if I'm wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment