input_html options get applied to labels of BooleanInputs #995

Closed
RobinClowers opened this Issue Feb 6, 2014 · 1 comment

Projects

None yet

1 participant

@RobinClowers

I noticed there is a comment in the source about this behavior:

      # TODO: why are we merging `input_html_options` and then making some of the irrelevant ones `nil`?
      # Seems like we should be selectively including from input_html_options (a whitelist) instead of 
      # excluding (blacklist).
@justinfrench justinfrench added a commit that referenced this issue Apr 5, 2014
@justinfrench Whitelist only `for` and `class` attributes on BooleanInput label.
I can't find a decent reason to be merging with `input_html_options` and fussing around with it like it was.

Closes #995
1d04300
@justinfrench justinfrench closed this in #1016 Apr 6, 2014
@RobinClowers

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment