The builder object sometimes loses the custom_namespace attribute in threadsafe mode #998 #1003

Closed
wants to merge 6 commits into
from

Projects

None yet

2 participants

@hudson-gev-art

I've added a failing spec to trigger the custom_namespace error on the form builder as discussed in issue #998

@justinfrench
Owner

@hudson-gev-art are the failure errors you're seeing on Travis what you were expecting and what you saw locally? I'm guessing not. We might need to add JRuby to the build matrix as part of this work.

@hudson-gev-art

The travis error is different than what I was seeing. Looks like this issue may be jruby specific.

I added jruby to the build matrix on my fork. You can check out the build https://travis-ci.org/hudson-gev-art/formtastic/jobs/19999829

The custom_namespace issue is there as well as a few other issues that manifested in the different environment. I'm not sure what you think the next steps should be ( if any ) but I'll offer as much help as I can. Thanks,

Hudson

@justinfrench
Owner

Hey there @hudson-gev-art. We need someone familiar with jruby to get in there and see if they can make progress on any of those failing tests. I can ask @charliesome if he has any ideas on the threading issue with the class attributes on Builder (custom_namespace, etc), but in order to support jruby, we really need someone to champion it and maybe even join the core group.

If you're up for the challenge, I'd be thrilled to see wider support.

Compared to other open PRs and issues, I don't think I'm going to be able to make progress on this for quite a while.

@hudson-gev-art

Thanks for looking into this. I've closed the issue for now as it will take me some time to familiarize myself with the code enough to start looking into the jruby issues.

@justinfrench
Owner

Closing for now, we're not actively making progress on this, but more than happy to re-open when we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment