Skip to content

Fix for #657, rc4 broken with rails 3.1.0.rc4/rc5 (now really navigasmic) #658

Merged
merged 1 commit into from Aug 18, 2011

3 participants

@gucki
gucki commented Aug 18, 2011

Please check: I'm not really sure wether to use @@builder or options[:builder] in this place.

@sobrinho sobrinho merged commit a95479e into justinfrench:master Aug 18, 2011
@sobrinho
Collaborator

Pulled, thanks!

@justinfrench
Owner

Could you please follow this up with a test case so that we don't re-introduce a regression? At the very least a comment above the line. I still don't understand why this patch helped, and under what circumstances. Then again, it is 7am :)

@gucki
gucki commented Aug 19, 2011

@justinfrench It seems there's a scoping/ context issue when using builder. When using navigasmic, builder is a reference to Navigasmic::HtmlNavigationBuilder:Class instead of Formtastic::FormBuilder. I'm not really sure why, because I don't know how exactly the mattr_accessor works. I thought it doesn't create instance accessors - as in many places @@builder instead of the accessor builder is used - and so I simply adjusted this call too. I'll investigate further and try to add a test case.

@sobrinho
Collaborator

I'm working on this.

@sobrinho
Collaborator

Done: c64f967

@justinfrench
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.