Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix formtastic 1.2 multiple select clearing #799

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

This approach is similar to what's needed to clear multiple checkboxes.

@felixbuenemann felixbuenemann Insert hidden field for multiple selects to allow clearing.
This approach is similar to what's needed to clear multiple
checkboxes.
f2d44a9

If someone can get the 1.2 specs to run it would be great to verify this doesn't break anything. Also it would be good to extend the spec to check for the hidden field.

FYI the error I'm getting on about 95% of the specs:

     wrong number of arguments (1 for 0)

I don' really have an idea why. Maybe because of the way the method is build through module_eval in lib/formtastic.rb:1923

I tried running the specs with both ruby-1.8.7 and 1.9.2.

kchien commented Feb 16, 2012

@fbuenemann - thanks to @justinfrench, I made sure I was using Rails 2.3.x, and all of the specs pass.
Did you try with Rails 3 or 2.3.x?

Bundler picked up Rails 3.1.3.
Update: OK, specs work and are all passing when using ruby-1.8.7 and export RAILS_2=1

Owner

justinfrench commented Feb 17, 2012

I think we're at the point where this and #802 are duplicates. Since #802 has tests, let's close this and pick it up there. I've posed one question already.

agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment