Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rename DateInput, TimeInput, DatetimeInput: #826

Merged
merged 1 commit into from Mar 25, 2012

Conversation

Projects
None yet
3 participants
Owner

justinfrench commented Mar 18, 2012

  • :as => :date becomes :as => :date_select
  • :as => :time becomes :as => :time_select
  • :as => :datetime becomes :as => :datetime_select
  • newly named inputs have a different css class on the wrapper (li.date_select, etc)
  • existing :date, :time, :datetime still work (with original css wrapper class)
  • deprecated existing inputs with warning
  • :date, :time and :datetime database columns now map to these new selects
  • CHANGELOG

This paves the way for a DatePickerInput (etc) to be introduced with less confusion, and potentially defaulting DateInput, TimeInput and DatetimeInput to the HTML5 date picker versions in a future release.

Owner

justinfrench commented Mar 22, 2012

@sobrinho @yabawock @haines @twalpole care to take a look?

Collaborator

twalpole commented Mar 22, 2012

@justinfrench Getting on a plane right now, i can take a look tonight/tomorrow

Collaborator

sobrinho commented Mar 23, 2012

👍

Collaborator

twalpole commented Mar 23, 2012

+1
Looks great - only issue I see is with the commit message which states
:as => :datetime becomes :as => :time_select when its actually renamed to :datetime_select

Rename DateInput, TimeInput, DatetimeInput:
* :as => :date becomes :as => :date_select
* :as => :time becomes :as => :time_select
* :as => :datetime becomes :as => :datetime_select
* newly named inputs have a different css class on the wrapper (li.date_select, etc)
* existing :date, :time, :datetime still work (with original css wrapper class)
* deprecated existing inputs with warning
* :date, :time and :datetime database columns now map to these new selects
* CHANGELOG

justinfrench added a commit that referenced this pull request Mar 25, 2012

Merge pull request #826 from justinfrench/rename_timeish_inputs
Rename DateInput, TimeInput, DatetimeInput:

@justinfrench justinfrench merged commit e971195 into master Mar 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment