Skip to content

Add easier method of suppressing labels on timeish inputs #866

Merged
merged 2 commits into from Jul 9, 2012

2 participants

@jpmckinney

f.input :attribute, :datetime_select, labels: {year: nil, month: nil, day: nil, hour: nil, minute: nil, second: nil} is not as nice as labels: false. This pull request allows users to set the labels option to false (or nil) to suppress fragment labels on Timeish inputs.

@jpmckinney

Includes specs.

@justinfrench
Owner

Nice, can you document this new variation of the :labels alongside any existing mentions please? I think that narrows it down to Timeish

@jpmckinney

Added :)

@justinfrench justinfrench merged commit f3928a6 into justinfrench:master Jul 9, 2012
@justinfrench
Owner

Thanks, merged!

@justinfrench
Owner

@jpmckinney this broke the build under REE on Rails edge, not all that worried as it seems to be unrelated to your change and is actually not very informative, but thought you'd like to know in case you're interested or saw something similar locally

@jpmckinney

Those errors are usually intermittent on Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.