[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts #421
Conversation
|
LGTM |
* Split $objectDefinition into $schema and $properties (#411) Object validation attempts to use a single variable to store both the object definition, and its properties. This causes validation to be incomplete where "properties" is not set, but "additionalProperties" is. This commit fixes both bugs in issue #353. * Issue-414: Allow The Option of T or space for Date time. (#415) * Testcase for minProperties with properties defined (#416) + Fix Test * Tweak phpdocumentor dependency to avoid install conflicts (#421) * [BUGFIX] Cast empty schema arrays to object (#409) * Cast root to object * Use function_exists to allow polyfill compatibility * Move array->object conversion to SchemaConstraint & SchemaStorage Fixes issue #408 * fix bug when applying defaults for array items when the schema is for (#405) all items and add support for minItems when applying defaults * [BUGFIX] Split "uri" format into "uri" & "uri-reference", fix meta-schema bug (#419) * Split "uri" format into "uri" and "uri-reference" * Correct format for id & $ref in draft-03/04 meta-schemas See json-schema-org/JSON-Schema-Test-Suite#177 (comment)
|
I'm still having the issue, it breaks on phpdocumentor 2.9.0, here's my steps to reproduce the issue. to solve the issue, change phpdocumentor/phpdocumentor require-dev dependency from ^2.7 to ^2.9 but didn't pass the test :| |
|
@chocopowwwa That's really weird - this problem is definitely solved on Travis (see here). Which PHP version are you using? Can you please confirm the commit hash of origin/6.0.0-dev that you are using to test? |
|
Hi, here's my details: Commit Hash:
|
|
ahh okay, turns out i'm using different phpunit version mine is 5.7.19 |
|
That would do it ;-). PHPUnit 5 isn't compatible with PHP 5.3 unfortunately, so this library is stuck with PHPUnit 4.8. |
|
Just to clarify, before I assume this is resolved - am I correct in my understanding that you had manually changed the PHPUnit dependency version in |
|
nope, i run phpunit 5 from my composer global the install error caused by |
|
OK - so the install problem is still there on your system, when using Are you forcing any other package versions? |
|
@erayd are you able reproduce the issue? |
|
@chocopowwwa I have not managed to reproduce this since I fixed it the first time around, either locally on my dev system or on Travis. I'll have another crack at this tomorrow. In the meantime, any detail you can provide regarding your environment would be extremely helpful - in particular, anything that deviates from defaults. As a temporary workaround, you can simply remove phpdocumentor completely. This will prevent you from building the API documentation, but nothing else, and the API docs are a complete mess at the moment anyway - sorting the documentation is one of the many things on my to-do list. |
|
@chocopowwwa I'm still not able to reproduce this. Could you please run the script below exactly as it appears here, and paste the full output: php --version
composer --version
cd /tmp
git clone https://github.com/justinrainbow/json-schema.git
cd json-schema
git checkout 6.0.0-dev
grep phpdocumentor composer.json
composer install
rm -rf vendor composer.lock
git checkout 5.x.x
grep phpdocumentor composer.json
composer install |
|
https://gist.github.com/chocopowwwa/8b3fe8cf246039cefdf0fbf91c805003 |
What
phpdocumentor/phpdocumentorrequire-dev dependency from~2to^2.7.Why