Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *Of properties to RefResolver #78

Merged
merged 2 commits into from Dec 7, 2013

Conversation

@hglattergotz
Copy link
Contributor

@hglattergotz hglattergotz commented Oct 10, 2013

The RefResolver currently skips any part of the schema that contains
'allOf', 'anyOf' or 'oneOf'. This prevents proper resolving of
references ($ref) that are inside of an array that is part of the above
mentioned properties.
Add the three property names to the array that is used to execute
resolveArrayOfSchemas().

The RefResolver currently skips any part of the schema that contains
'allOf', 'anyOf' or 'oneOf'. This prevents proper resolving of
references ($ref) that are inside of an array that is part of the above
mentioned properties.
Add the three property names to the array that is used to execute
resolveArrayOfSchemas().
In JsonSchema\Tests\RefResolverTest::testResolve the
JsonSchema\RefResolver::resolveArrayOfSchemas method is now called 7
instead of 4 times due to the addition of 'oneOf', 'allOf' and 'anyOf'.
Change expected count from 4 to 7 in resolveProvider.
@shouze
Copy link

@shouze shouze commented Nov 7, 2013

👍

@tyx
Copy link

@tyx tyx commented Nov 7, 2013

Great job !

We need this 👍

ping @justinrainbow

@jeremyFreeAgent
Copy link

@jeremyFreeAgent jeremyFreeAgent commented Nov 7, 2013

👍

@stephpy
Copy link

@stephpy stephpy commented Nov 7, 2013

Good improvement.

@doxav
Copy link

@doxav doxav commented Nov 7, 2013

We need it!

justinrainbow added a commit that referenced this pull request Dec 7, 2013
Add *Of properties to RefResolver
@justinrainbow justinrainbow merged commit dea4e26 into justinrainbow:master Dec 7, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
hakre pushed a commit to hakre/json-schema that referenced this pull request Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.