New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testimonials Standard #12

Closed
philiparthurmoore opened this Issue Aug 2, 2014 · 27 comments

Comments

Projects
None yet
9 participants
@philiparthurmoore
Copy link

philiparthurmoore commented Aug 2, 2014

I've written about this here and would love to hammer this out soon. I think it'd be a very quick and solid win for all.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 2, 2014

Key points:

WordPress.com has a Testimonials custom post type implemented in Jetpack and for all of its users on WordPress.com. You can view the code here, which needs work. The steps to view Testimonials in Jetpack now are as follows:

  1. Install Jetpack
  2. Install Motif (using the one from the Theme Showcase is fine)
  3. Start adding Testimonials.

Other than the Issue I raised a while back which still needs love here, there's not been much movement on improving Testimonials. I think that we can take what Automattic has done, make a V2 of it, get a super-solid standardized version of Testimonials done, and call it a win.

The reason I've chosen these first is because it's very quick relative to the others, and I think that if we can build some momentum with a standardization win, it'd encourage everyone to get on board with doing this for the CPTs that are more difficult.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 2, 2014

The anatomy of good testimonials:

  1. The person who gave it
  2. The actual testimonial
  3. A link to the person's website
  4. An image of the person who gave the testimonial
  5. A page that lists all the testimonials in a nice fashion

Am I missing anything?

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 2, 2014

Here's WooThemes' implementation: https://github.com/woothemes/testimonials/

@justintadlock

This comment has been minimized.

Copy link
Owner

justintadlock commented Aug 2, 2014

I also have testimonials I've built for custom sites and would love to see this standardized. I agree that this should be one the easier ones to tackle and is a good one to start on.

Here's a wiki page for this standard: https://github.com/justintadlock/content-type-standards/wiki/Content-Type:-Testimonial

I think we can all agree on the testimonial post type. That seems pretty straightforward to me.

The person who gave it

Both Jetpack and WooThemes use the post title to handle this.

The actual testimonial

Post content.

A link to the person's website

I'd go with a meta key of _testimonial_url for this similar to what we've done for _project_url in the portfolio standard.

An image of the person who gave the testimonial

The featured image should work nicely for this. I think both Woo and Jetpack do this, correct?

@GaryJones

This comment has been minimized.

Copy link

GaryJones commented Aug 2, 2014

Personally, if testimonials are used as social proof at the point of convincing a user to follow a CTA, then a link away to another website is a bad idea.

However, many will disagree with that, so including a URL field should be part of the standard, and implementers can choose whether to use it or not.

@SherryBCreative

This comment has been minimized.

Copy link

SherryBCreative commented Aug 2, 2014

This is very similar to a Quotes CPT I made for a client. The Quotes implemented a Date the Quote was made. Date may be applicable with Testimonials as well.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 3, 2014

@GaryJones:

Personally, if testimonials are used as social proof at the point of convincing a user to follow a CTA, then a link away to another website is a bad idea.

I hadn't thought of that. Interesting.

My mind was also on showcases, where a theme seller sells a theme and a customer says how great the theme is. In that case linking to his/her site, which showcases the theme in use, is pretty strong proof that a theme has real value to someone.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 3, 2014

@SherryBCreative:

This is very similar to a Quotes CPT I made for a client. The Quotes implemented a Date the Quote was made. Date may be applicable with Testimonials as well.

Great. I think post dates can be used for this sort of thing.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 3, 2014

Does this look like everything that could be needed in a single Testimonial?

mockup

The visual organization of these blocks isn't important. Think of it like a toolbox or recipe board.

@georgestephanis

This comment has been minimized.

Copy link

georgestephanis commented Aug 3, 2014

@SherryBCreative: Sheer pedantism, but quote is a verb, quotation is a noun. Any custom post type should be called quotation, not quote. (Apologies for the pedantism)

@justintadlock

This comment has been minimized.

Copy link
Owner

justintadlock commented Aug 3, 2014

On the subject of quotes, they are actually very different from testimonials. Testimonials are a subset of quotes with their own specific use cases. They are so widely used and different than most other types of quotes that they warrant their own, separate post type. When I think of having a quote post type, I'm thinking more along the lines of running this type of site:
http://www.brainyquote.com


If we need a couple of real-world examples of testimonials, here's how I use them:


Does this look like everything that could be needed in a single Testimonial?

@philiparthurmoore - That looks pretty good to me.

I thought about bringing up using Gravatar because I use it on my site, so having an email meta key is a good thing.

The one thing that might be missing is a taxonomy for grouping testimonials. Personally, I use more of a hidden taxonomy for being able to pull in testimonials for certain things like just testimonials for the "plugindevbook" page I listed above. It's possible that this might start getting into specific use cases though rather than being a general standard because I could also see other people wanting to tie this into something like products.

Anyway, I've laid out what all we have thus far in the wiki page:
https://github.com/justintadlock/content-type-standards/wiki/Content-Type:-Testimonial

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 3, 2014

@justintadlock Totally agree we need to take into account grouping. The above image is just for single testimonials. Let me post another one in my morning that takes into account how we might group them and also handle them within the Customizer.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 4, 2014

Okay. Here's what all Testimonials together would look like. Again, this shouldn't be taken too literally visually. Is this overkill? I've taken what Jetpack has done and also taken into account grouping, as @justintadlock mentioned above.

all-testimonials

Note the page slug, the page title, the description, and the fact that the testimonials can be grouped together. The featured image already exists in Jetpack, so I've taken that into account.

@JakePT

This comment has been minimized.

Copy link

JakePT commented Aug 4, 2014

I have to really strongly disagree with using a Gravatar for the image. Seems like a very insular approach.

The company I work for makes sites for small-business owners and we have a testimonial plugin of our own that they use. The idea that any of their clients, let alone ours, will have a Gravatar is crazy. It is also crazy to expect them to get all these people to sign up for one.

Additionally, you're then leaving a significant part of the appearance of your testimonials page up to the clients. What if I'm a wedding photographer and want to put my customer testimonials up with a photo from their wedding? Assuming they have a Gravatar account, what's the chance their going to want their avatar to be their wedding photo?

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 4, 2014

@JakePT: This is just a discussion of standardization. So it means that IF someone uses gravatars, they should use the meta key _testimonial_email (see this page). It doesn't mean that you have to use it. This is just to get a solid working standardization in place so that plugins and themes play nicely together.

@hchouhan

This comment has been minimized.

Copy link

hchouhan commented Aug 4, 2014

@JakePT the testimonial CPT will still support featured image. In the theme, instead of Gravatar code, one simply could use the featured image.

@Stephen-Cronin

This comment has been minimized.

Copy link

Stephen-Cronin commented Aug 4, 2014

Question: What if there is a video associated with each testimonial? I'm guessing this is something that will probably happen more often in future. Would this just be part of the 'post' content? Or is it worth having a separate field so it can be pulled out instead of a featured image?

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 4, 2014

@Stephen-Cronin: My knee-jerk thought is that it should be part of the post content and up to theme and plugin developers to use the videos how they want, because if one video is used there's no telling if two or three will also be used.

@kadamwhite

This comment has been minimized.

Copy link

kadamwhite commented Aug 4, 2014

Additionally (to break my silence in this repo), any video could and should suggest any number of images... Better to be explicit.

@GaryJones

This comment has been minimized.

Copy link

GaryJones commented Aug 4, 2014

I'm +1 for everything that's been said so far, including the grouping of testimonials under a taxonomy. Testimonial Group, or stick with Testimonial Category for consistency with other core and custom post types?

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 4, 2014

@justintadlock What do you think about linking to the Isssue threads in the Wiki? e.g. linking to this thread from this page? I'm thinking of the future when someone may wonder why something is the way it is.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 4, 2014

@GaryJones: I'm all for keeping the Category name for consistency.

@justintadlock

This comment has been minimized.

Copy link
Owner

justintadlock commented Aug 4, 2014

I have to really strongly disagree with using a Gravatar for the image. Seems like a very insular approach...

@JakePT - "Gravatar" is really the wrong term. "Avatar" is technically correct. WordPress has a get_avatar() function. It defaults to the Gravatar service, but it is in no way the only way to handle avatars. The implementation of avatars is not really our concern; I was just pointing it out in case you didn't know.

If your clients would never use Gravatar, there'd be no need to use that particular part of the standard. Just stick with the featured image.

Question: What if there is a video associated with each testimonial? I'm guessing this is something that will probably happen more often in future. Would this just be part of the 'post' content? Or is it worth having a separate field so it can be pulled out instead of a featured image?

@Stephen-Cronin - I'd say it'd probably be part of the post content.

I'm +1 for everything that's been said so far, including the grouping of testimonials under a taxonomy. Testimonial Group, or stick with Testimonial Category for consistency with other core and custom post types?

@GaryJones - Category is fine by me.

I believe we really only need one taxonomy too. That'll probably do okay for the majority of use cases.

What do you think about linking to the Isssue threads in the Wiki? e.g. linking to this thread from this page? I'm thinking of the future when someone may wonder why something is the way it is.

@philiparthurmoore - Yes, we should link to this issue in the wiki. I'll go ahead and do that.

@justintadlock justintadlock referenced this issue Aug 5, 2014

Open

Standards Tracking #13

2 of 28 tasks complete
@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 8, 2014

I've just had a long chat with @michaeldcain and on the topic of the Customizer, I think I was dead wrong about the importance of the Customizer in these chats. Because Jetpack appears to be the only plugin that does anything with Testimonials in the Customizer, I don't really see a reason to have any standardization efforts around that, since we've covered everything else above already.

I'd say we're 99% there with Testimonials standardization, but there is one remaining issue that I'll post separately shortly before closing this out.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 8, 2014

Waiting to hear back about #15 before closing this out.

@philiparthurmoore

This comment has been minimized.

Copy link

philiparthurmoore commented Aug 12, 2014

I think we're good to close this out and call it done. What do you think @justintadlock?

@justintadlock

This comment has been minimized.

Copy link
Owner

justintadlock commented Aug 12, 2014

Everything looks good to me. I've updated the example code:
https://github.com/justintadlock/content-type-standards/tree/master/testimonials

Any changes needed can be addressed in new tickets. Let's close this one and move on to other things. Great job, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment