Added CSS RTL Support. #4

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@KingYes

KingYes commented Oct 24, 2012

Hey justintadlock,
I just add new support for RTL support..

Thanks you for your good code. :)

Yakir.

@KingYes KingYes referenced this pull request Oct 24, 2012

Closed

Add RTL Support.. #3

@justintadlock

This comment has been minimized.

Show comment Hide comment
@justintadlock

justintadlock Oct 25, 2012

Owner

I'm thinking about taking this a different direction and using the WordPress-generated "rtl" body class. It'll simplify the code and we won't need any additional files or PHP.

Owner

justintadlock commented Oct 25, 2012

I'm thinking about taking this a different direction and using the WordPress-generated "rtl" body class. It'll simplify the code and we won't need any additional files or PHP.

@KingYes

This comment has been minimized.

Show comment Hide comment
@KingYes

KingYes Oct 25, 2012

No Problem.

KingYes commented Oct 25, 2012

No Problem.

@justintadlock

This comment has been minimized.

Show comment Hide comment
@justintadlock

justintadlock Oct 25, 2012

Owner

8d1e743

I just committed a first-pass on RTL styles on the 0.2 branch. I don't really have a testing environment set up for this. Whenever you get a chance, let me know if it works for you.

Also, this code assumes that your WordPress theme correctly uses the body_class() function (most do).

Owner

justintadlock commented Oct 25, 2012

8d1e743

I just committed a first-pass on RTL styles on the 0.2 branch. I don't really have a testing environment set up for this. Whenever you get a chance, let me know if it works for you.

Also, this code assumes that your WordPress theme correctly uses the body_class() function (most do).

@KingYes

This comment has been minimized.

Show comment Hide comment
@KingYes

KingYes Oct 25, 2012

@justintadlock

This comment has been minimized.

Show comment Hide comment
@justintadlock

justintadlock Nov 8, 2012

Owner

I'm marking this as resolved. Everything seems to be in order in my tests. If anyone runs into any issues with it, let me know.

Owner

justintadlock commented Nov 8, 2012

I'm marking this as resolved. Everything seems to be in order in my tests. If anyone runs into any issues with it, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment