Supersubs script no longer required #29

Closed
philipnewcomer opened this Issue May 29, 2013 · 6 comments

Projects

None yet

2 participants

@philipnewcomer

As of Superfish 1.6, the Supersubs script is no longer required. See https://github.com/joeldbirch/superfish/blob/master/css/superfish.css#L58
I see you've updated to superfish 1.7.2 for Hybrid Core 1.6, and just wanted to point this out in case you weren't aware of it.

@justintadlock

How would removing Supersubs change things for users who aren't using the that particular CSS? I'm thinking they'd still need the plugin.

@philipnewcomer

Yes, AFAIK if they're using the old CSS, they still need the supersubs plugin.

If developers are using the the bundled library CSS styles (hybrid-core/css/drop-downs.css for example), those bundled CSS files can (should?) be updated with the new code, and everything still works, but without the supersubs plugin (correct me if I'm wrong here). As I understand it, the problem would only occur if they've copied the drop-downs CSS into their own stylesheet, and are not using the (updated) CSS directly from the library. In that case, I think developers could simply be made aware that in 1.6, the dropdowns CSS, as well as the dropdowns JS has been updated, and if they've copied the old version of the CSS into the theme, they should update their CSS to work with the new JS. But most developers (I would expect) are using the dropdowns CSS from the framework itself, and would therefore be using the new CSS, or am I missing something?

As an aside: Is GitHub the best place for me to bring up things like this, or would you rather have it take place on the Theme Hybrid forums?

@justintadlock

A few points (mostly just reminders to myself):

  • I made it easy in 1.5 to include the most up-to-date versions of the framework's CSS files, but this hasn't always been the case.
  • Not all themes use or even start their design from the base drop-downs.css.
  • The drop-downs.css is meant to be just the "essential" Superfish CSS rather than the "skin" CSS, which is what the new code falls under. Though, I'm not sure if that matters.

I think the best course of action should be to make an official announcement for the 1.6 release that Supersubs will be removed in 1.7. Then, drop it in the 1.7 release and update the drop-downs.css file.

Another thing I'm doing in 1.7 is evaluating whether we should continue having Superfish bundled (it'd have to be phased out if we got rid of it) because CSS3 makes much of it unnecessary. But, I'll save that discussion for later.

As an aside: Is GitHub the best place for me to bring up things like this, or would you rather have it take place on the Theme Hybrid forums?

Either is fine. GitHub works better for helping me keep track of things, but the forum usually gets more discussion.

@philipnewcomer

Okay, feel free to close this issue as you see fit.

Re: Superfish, it does do a lot of stuff that is helpful for modern mobile devices, such as enhancing the menu functionality on touch devices like the iPad that don't really have hover states, but like you said that's a discussion for another time.

@justintadlock

I'm marking this as a 1.7 feature. We should drop Supersubs then.

@justintadlock

I'm closing this as Superfish and related scripts and CSS have been removed from HC 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment