Theme Check Refuse All Shortcode #84

Closed
turtlepod opened this Issue Nov 16, 2014 · 13 comments

Comments

Projects
None yet
5 participants
@turtlepod

Just Info, I update a theme to wp.org and the result:
https://dl.dropboxusercontent.com/u/32880842/etc2/shortcode-reject.png

I remove shortcodes.php from HC and it's accepted.

So we no longer able to add any shortcode in theme (even for non-content shortcodes).
(it's frustrating, the same with wp_title() stuff.)

@justintadlock

This comment has been minimized.

Show comment
Hide comment
@justintadlock

justintadlock Nov 16, 2014

Owner

I'd like to remove them all. Theme Check shouldn't be blocking all shortcodes though.

I'll see if I can get in touch with the TRT about this because this is not something that the team has agreed to do. Right now, Slack is once again down for me and we no longer have the mailing list. It's kind of tough to communicate.

Owner

justintadlock commented Nov 16, 2014

I'd like to remove them all. Theme Check shouldn't be blocking all shortcodes though.

I'll see if I can get in touch with the TRT about this because this is not something that the team has agreed to do. Right now, Slack is once again down for me and we no longer have the mailing list. It's kind of tough to communicate.

@turtlepod

This comment has been minimized.

Show comment
Hide comment
@turtlepod

turtlepod Nov 16, 2014

actually, after thinking about it. you are right.
it's better to just remove the shortcodes from HC.

it's easier for both HC user and TRT.

actually, after thinking about it. you are right.
it's better to just remove the shortcodes from HC.

it's easier for both HC user and TRT.

@jayj

This comment has been minimized.

Show comment
Hide comment
@jayj

jayj Nov 16, 2014

But it should still be fixed. Removing shortcodes is not always possible. For example, Cakifo is still using apply_atomic_shortcode and that probably won't change. If this is kept in place, it means I can no longer update Cakifo.

jayj commented Nov 16, 2014

But it should still be fixed. Removing shortcodes is not always possible. For example, Cakifo is still using apply_atomic_shortcode and that probably won't change. If this is kept in place, it means I can no longer update Cakifo.

@Rarst

This comment has been minimized.

Show comment
Hide comment
@Rarst

Rarst Nov 16, 2014

Contributor

apply_atomic_shortcode() had been deprecated in Hybrid Core v2 so you are already update blocked on that.

Contributor

Rarst commented Nov 16, 2014

apply_atomic_shortcode() had been deprecated in Hybrid Core v2 so you are already update blocked on that.

@jayj

This comment has been minimized.

Show comment
Hide comment
@jayj

jayj Nov 16, 2014

How so?

jayj commented Nov 16, 2014

How so?

@Rarst

This comment has been minimized.

Show comment
Hide comment
@Rarst

Rarst Nov 16, 2014

Contributor

There is nothing to use there anymore, so if you want to update to current Core version you'll have to refactor it away anyway.

Contributor

Rarst commented Nov 16, 2014

There is nothing to use there anymore, so if you want to update to current Core version you'll have to refactor it away anyway.

@jayj

This comment has been minimized.

Show comment
Hide comment
@jayj

jayj Nov 16, 2014

Cakifo most likely won't be updated so that's not a problem.

jayj commented Nov 16, 2014

Cakifo most likely won't be updated so that's not a problem.

@Rarst

This comment has been minimized.

Show comment
Hide comment
@Rarst

Rarst Nov 16, 2014

Contributor

Then I am not following why is removing shortcodes from Core an issue for you? If you refer to general shortcodes situation context with TRT this probably isn't the best place for it. :)

Contributor

Rarst commented Nov 16, 2014

Then I am not following why is removing shortcodes from Core an issue for you? If you refer to general shortcodes situation context with TRT this probably isn't the best place for it. :)

@jayj

This comment has been minimized.

Show comment
Hide comment
@jayj

jayj Nov 16, 2014

Oh, I meant that the Theme uploader should be fixed, not HC as answer to @turtlepod "it's better to just remove the shortcodes from HC."

Sorry for the confusion

jayj commented Nov 16, 2014

Oh, I meant that the Theme uploader should be fixed, not HC as answer to @turtlepod "it's better to just remove the shortcodes from HC."

Sorry for the confusion

@justintadlock

This comment has been minimized.

Show comment
Hide comment
@justintadlock

justintadlock Nov 17, 2014

Owner

Removing shortcodes from HC is something I want to do long term. I just noted it above.

This issue should definitely be fixed in Theme Check. I've reported it, but I and the other TRT admins aren't in control of it. So, we'll have to wait and see.

Owner

justintadlock commented Nov 17, 2014

Removing shortcodes from HC is something I want to do long term. I just noted it above.

This issue should definitely be fixed in Theme Check. I've reported it, but I and the other TRT admins aren't in control of it. So, we'll have to wait and see.

@justintadlock

This comment has been minimized.

Show comment
Hide comment
@justintadlock

justintadlock Nov 25, 2014

Owner

We discussed this for a moment in #themereview on Slack. The tentative decision is to ban all shortcodes, which I'm supportive of. However, there will be time for discussion on this on the Make Themes blog.

As of right now, my plan is to remove all remaining shortcodes regardless of the final decision.

Owner

justintadlock commented Nov 25, 2014

We discussed this for a moment in #themereview on Slack. The tentative decision is to ban all shortcodes, which I'm supportive of. However, there will be time for discussion on this on the Make Themes blog.

As of right now, my plan is to remove all remaining shortcodes regardless of the final decision.

@saas786

This comment has been minimized.

Show comment
Hide comment
@saas786

saas786 Dec 24, 2014

Hi @justintadlock

What about overriding the core shortcodes like Gallery? Which your extension Cleaner Gallery overrides it, will it be not allowed as well? (In theme)?

saas786 commented Dec 24, 2014

Hi @justintadlock

What about overriding the core shortcodes like Gallery? Which your extension Cleaner Gallery overrides it, will it be not allowed as well? (In theme)?

@justintadlock

This comment has been minimized.

Show comment
Hide comment
@justintadlock

justintadlock Dec 24, 2014

Owner

Filtering the gallery hook is different and allowed.


Closing this ticket since shortcodes are now gone in the latest on the 2.0 branch.

Owner

justintadlock commented Dec 24, 2014

Filtering the gallery hook is different and allowed.


Closing this ticket since shortcodes are now gone in the latest on the 2.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment