Bug fix: pagination links don't work when you have a get parameter added... #57

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

enejb commented Jan 27, 2014

Fix for issue #56 Loop Pagination Extension Bug

Owner

justintadlock commented Jan 27, 2014

I'm going to dig into this a bit more. It's something we've known about but haven't had a good solution for handling. Can you post the patch against version 1.6 or 2.0 branch and not the stable, master branch?

enejb commented Jan 28, 2014

Hi Justin

I just committed a pull request against the 1.6 branch and the 2.0 branch
as requested.

Cheers

On Mon, Jan 27, 2014 at 1:24 PM, Justin Tadlock notifications@github.comwrote:

I'm going to dig into this a bit more. It's something we've known about
but haven't had a good solution for handling. Can you post the patch
against version 1.6 or 2.0 branch and not the stable, master branch?

Reply to this email directly or view it on GitHubhttps://github.com/justintadlock/hybrid-core/pull/57#issuecomment-33424468
.

Just tested the diff against 2.0.0 and it appears to fix the problem for archive navigation.

Owner

justintadlock commented Mar 16, 2015

Loop Pagination was dropped in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment