Skip to content
This repository


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Use switch rather than if-else in sink_input_pop_cb #13

justinzane opened this Issue · 1 comment

1 participant

Justin Zane Chudgar
Justin Zane Chudgar

In sink_input_pop_cb() (and in similar cases elsewhere), it would be
better to use a switch statement for handling the different cases of the
filter type instead of a series of "else ifs".
It is taking me a little while to remove the voice of some professor saying that "switch" "case" and "goto" were cardinal sins. I'm still getting a feel for the appropriate context for various c control flow mechanisms. Thanks.

Justin Zane Chudgar

Moved filter logic to pulsecore/biquad-filter.c. Used switch there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.