Fixed MacOS install and added test #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjavac
approved these changes
May 23, 2022
…l.sh`. 2. Changed OS+CPU logic to gracefully error in cases of unsupported combinations in `install.sh`. 3. Allowed for `install.sh` to receive an optional argument for installation from a local copy of dvm for easy testing. 4. Updated CI to test that `install.sh` works on MacOS and Linux, via changes in `.github/workflows/ci.yml`.
|
@justjavac fixed CI issue if you want to try re-running tests 😄 |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR #89 broke
install.shscript on MacOS for all CPU architectures. This PR fixes that break and adds test to ensure it doesn't happen in the future.Related Issues and PRs
Changes
install.sh.install.sh.install.shto receive an optional argument for installation from a local copy of dvm for easy testing.install.shworks on MacOS and Linux, via changes in.github/workflows/ci.yml.