Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude closed discussions #4

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

jslirola
Copy link
Contributor

I added a change that I needed for a forum and wanted to share the code here. I don't intend for it to be merged as not everyone wants to exclude closed discussions, but you could try adding an option in the extension that allows you to set this.

What do you think about this? I imagine that I should create a migration to store the value of that preference, but I have no experience with these changes, if it's okay with you, you can contribute to this branch or explain me how to do it.

@jslirola jslirola marked this pull request as ready for review April 9, 2023 15:57
@jslirola
Copy link
Contributor Author

jslirola commented Apr 9, 2023

I learned how to create settings in the admin panel and included one for this case.

@justoverclockl justoverclockl merged commit c20780e into justoverclockl:main Apr 11, 2023
@justoverclockl
Copy link
Owner

merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants