Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buffer pool metrics #175

Merged

Conversation

@matsumana
Copy link
Contributor

@matsumana matsumana commented Aug 13, 2018

Hello.

I want to monitor buffer pool metrics.
Because Netty uses direct buffer.

We can get such metrics via Elasticsearch's /_nodes/_local/stats API.

"jvm": {
    "buffer_pools": {
        "direct": {
            "count": 40,
            "used_in_bytes": 135771544,
            "total_capacity_in_bytes": 135771543
        },
        "mapped": {
            "count": 0,
            "used_in_bytes": 0,
            "total_capacity_in_bytes": 0
        }
    },
    ...
},
...

The following metrics will be added by this PR.

# HELP elasticsearch_jvm_buffer_pool_used_bytes JVM buffer currently used
# TYPE elasticsearch_jvm_buffer_pool_used_bytes gauge
elasticsearch_jvm_buffer_pool_used_bytes{cluster="shopsearch-test",es_client_node="true",es_data_node="true",es_ingest_node="true",es_master_node="false",host="data001",name="data001",type="direct"} 1.35840543e+08
elasticsearch_jvm_buffer_pool_used_bytes{cluster="shopsearch-test",es_client_node="true",es_data_node="true",es_ingest_node="true",es_master_node="false",host="data001",name="data001",type="mapped"} 0
@zwopir
Copy link
Collaborator

@zwopir zwopir commented Aug 13, 2018

thanks for the PR. Looks good

@zwopir zwopir merged commit 484a174 into justwatchcom:master Aug 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matsumana
Copy link
Contributor Author

@matsumana matsumana commented Aug 13, 2018

Thank you for merging.

BTW, when will the next version (perhaps, 1.0.3 rc2?) be released?

@zwopir
Copy link
Collaborator

@zwopir zwopir commented Aug 13, 2018

I wanted to give #162 a chance to make it into the next RC. So I'm waiting a few more days. I hope to have a release w/ or w/o #162 by the end of the week

@matsumana
Copy link
Contributor Author

@matsumana matsumana commented Aug 13, 2018

Got it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants