Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass find includes symlinks #787

Closed
532910 opened this issue May 18, 2018 · 21 comments
Closed

gopass find includes symlinks #787

532910 opened this issue May 18, 2018 · 21 comments
Labels
can-not-reproduce Bug can't be reproduced help-wanted

Comments

@532910
Copy link

532910 commented May 18, 2018

As the pass itself and buggy tree,

% gopass find linux
...password-store
├── IT
│   └── linux.org.ru.gpg
└── shops
    ├── amazon.ca.gpg -> amazon.gpg
    ├── amazon.co.uk.gpg -> amazon.gpg
    ├── amazon.com.gpg -> amazon.gpg
    ├── amazon.de.gpg -> amazon.gpg
    ├── ebay.ca.gpg -> ebay.gpg
    ├── ebay.co.uk.gpg -> ebay.gpg
@dominikschulz
Copy link
Member

I'm not sure if I understand correctly, but gopass is supposed to include symlinks.
What would you expect?

@dominikschulz dominikschulz added the can-not-reproduce Bug can't be reproduced label May 24, 2018
@532910
Copy link
Author

532910 commented May 24, 2018

gopass find linux must not show amazon

@dominikschulz
Copy link
Member

I'm afraid, but it still don't get it. Maybe you could provide a listing of the directory on question along with the actual and expected outputs.

@532910
Copy link
Author

532910 commented May 25, 2018

Real output:

% gopass find linux
/home/sergio/.password-store
├── IT
│   └── linux.org.ru.gpg
└── shops
    ├── amazon.ca.gpg -> amazon.gpg
    ├── amazon.co.uk.gpg -> amazon.gpg
    ├── amazon.com.gpg -> amazon.gpg
    ├── amazon.de.gpg -> amazon.gpg
    ├── ebay.ca.gpg -> ebay.gpg
    └── ebay.co.uk.gpg -> ebay.gpg

Expected output:

% gopass find linux
/home/sergio/.password-store
└── IT
    └── linux.org.ru.gpg

@luxalpa
Copy link
Contributor

luxalpa commented May 25, 2018

Why does it show amazon? I can't reproduce this issue :<

@532910
Copy link
Author

532910 commented May 25, 2018

As amazon is a symlink.

@dominikschulz
Copy link
Member

gopass doesn't use tree.

@532910
Copy link
Author

532910 commented May 25, 2018

So it's another bug. Anyway, could you reproduce it?

@dominikschulz
Copy link
Member

I'm afraid I wasn't able to reproduce it.

@532910
Copy link
Author

532910 commented May 28, 2018

I'm sorry. It's bug of 1.2.0-1 from debian sid
All works fine with 1.7.2

@532910 532910 closed this as completed May 28, 2018
@falschparker82
Copy link
Contributor

@c-e-p-x-u-o - note that the Debian package is a completely independent version of gopass from Alexandre Viau: https://salsa.debian.org/debian/gopass

It does not have anything to do with https://github.com/gopasspw/gopass

@dominikschulz
Copy link
Member

In fact we aware of this naming conflict and have been in contact with the Debian maintainer of the other gopass package in Debian. Unfortunately we could not reach any compromise that would have made this situation obvious to users.

I'd suggest you raise an issue the Debian BTS to ask for clarification.

@532910
Copy link
Author

532910 commented May 29, 2018

Pleas add a big note about name conflict to not confuse users.

@dewey
Copy link

dewey commented May 29, 2018

It's all in the installation description: https://github.com/gopasspw/gopass/blob/master/docs/setup.md#ubuntu--debian-1

I'm not sure if users who blindly install something would read the note if there was one.

@dominikschulz
Copy link
Member

@dewey I fully agree, but we should probably at least add a small note about this naming issue on that page.

@532910
Copy link
Author

532910 commented May 29, 2018

You mean compromise with Alexandre Viau?

@532910
Copy link
Author

532910 commented May 29, 2018

The note should be on the main page.

@dominikschulz
Copy link
Member

Yes, we talked to him but couldn't reach any working compromise with him.

No, we probably won't put this on the front page. The setup instructions shuld be good.

@luxalpa
Copy link
Contributor

luxalpa commented May 29, 2018

The information about the other package with the same name could be added to the Issue Template?

@dominikschulz
Copy link
Member

@destructive-dragon Good idea, but we don't have an issue template, yet.
I'll add one.

dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue May 30, 2018
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue May 30, 2018
dominikschulz added a commit that referenced this issue May 30, 2018
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can-not-reproduce Bug can't be reproduced help-wanted
Projects
None yet
Development

No branches or pull requests

5 participants